FindBugs Plugin

Stephan,

Mate that's awesome! I'll try to check it out soon, but it looks neat regardless.

Cheers,

Mark C

I'm having problems getting this plugin to work.

It installs fine, and I can see that it accesses the maven-generated findbugs.xml file. But the results all display as 0 bugs, even though there are bugs recorded in the xml file. These 0 values appear as such in the database, so I believe the problem is somewhere near the initial parsing phase.

 I am using Bamboo 1.2.4.

Thanks,

Val Tarasyuk

The problem I was having with this plugin was that it only failed builds on a delta. Which made it not detect findbugs problems introduced together with other causes of build breakage. Also, it was possible to make a build "green" by simply re-running a failed build. This patch makes bamboo fail a build if there are any findbugs violations present. For an anal-retentive project manager like me, this is a must

Many thanks for releasing an updated findbugs plugin for Bamboo, I was waiting on this before migrating to Bamboo 2.

However, on my Bamboo installation the findbugs artifact copier is failling with the message "FindBugs plugin is not run because the build has failed". This is wrong, as the build has succeeded. Do you have any hints at resolving this?

Hi,

I have exactly the same problem Stephen reported (running Bamboo 2.0.1)... I'd love to have FindBugs reports integrated, looking forward to a patch.

Cheers,

Stanislaw

Hi,

 I am using the plugin, and I can see the violations graph (first screenshot above).  How do I get to the other charts/tables (screenshots 2 & 3)?

 Thanks!

Hi there,

It looks like enabling this plugin is causing the issue as below. Have you experienced anything similar?

Cheers,

Staszek

When I try to generate any report (e.g. Build Activity) for All builds or Last 90 days (did not check range), I'm getting an exception as pasted below. Reports work fine for smaller ranges, i.e Last 30 and 7 days.

Version: 2.0.5
Build: 807
Build Date: 24-Jun-2008

Stack Trace:

java.lang.IllegalArgumentException: Invalid complete key specified: null
at com.atlassian.plugin.ModuleCompleteKey.(ModuleCompleteKey.java:17)
at com.atlassian.plugin.DefaultPluginManager.getPluginModule(DefaultPluginManager.java:343)
at com.atlassian.bamboo.v2.build.trigger.TriggerReasonManagerImpl.getTriggerReason(TriggerReasonManagerImpl.java:32)
at com.atlassian.bamboo.index.BuildResultsSummaryDocumentFactory.getBuildResultsSummary(BuildResultsSummaryDocumentFactory.java:155)
at com.atlassian.bamboo.resultsummary.search.IndexedBuildResultsSearcherImpl.search(IndexedBuildResultsSearcherImpl.java:52)
at com.atlassian.bamboo.resultsummary.search.IndexedBuildResultsSearcherImpl.search(IndexedBuildResultsSearcherImpl.java:36)
at com.atlassian.bamboo.ww2.actions.reports.ViewReport.runReport(ViewReport.java:130)
at com.atlassian.bamboo.ww2.actions.reports.ViewReport.doGenerate(ViewReport.java:122)
at sun.reflect.GeneratedMethodAccessor1798.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)

[snip]

Good point! I've filed the issue here:

http://jira.atlassian.com/browse/FNDBUG-21\\

Cheers,

Staszek

I notice this project is in active development through your Jira page - when can we expect a version compatible with 2.1?

Just upgraded to Bamboo 2.1 and really miss this plugin already

Two days ago, I pulled from Trunk, built and installed the plugin and I am still seeing the: FindBugs plugin is not run because the build has failed.  The build was sucessful.   Any further developments in this area ?  Note, FindBugs was not run in this build plan.  Final comment,   Where is the mentioned patch for this and the parsing error reported ?

The following text is from the Checkstyle plugin comments and the error also effects  the Findbugs plugin:

Don't know where to post this bug, but there are issues (NumberFormatException), when you try to generate statistics, while the checkstyle plugin is active. (Unfortunately this effects all statistics - not only the checkstyle statistics).

These only happen under (for instance) a german locale.

To fix go to CheckstyleIndexReader.addBuildToSummary(..) and change the line:

double violations = Double.parseDouble(s);

to

double violations = NumberUtils.stringToDouble(s);

This is needed because in the PostBuildIndexWriter the NumberUtils.padWithZeros(..)-method is used, which respects the current locale (and generates strings like "000001234,00"). A simple Double.parse() thus is not enough.

The Findbugs plugin needs to be fixed in the following locations:

FindBugsLineRateViolationCollator Line 51: 

            violations += NumberUtils.stringToDouble(buildData.get(name));

TimePeriodFindBugsDeltaCollater Line 40:

                totalDelta += NumberUtils.stringToDouble(violations) / (double) getAuthorCount(results);
 

IndexReader , Line 60:

                NumberUtils.stringToDouble(s);

also in the catch-clause adding a "?" is a bad idea because it will crash later on again with a NumberFormatException, maybe use "0".

hi,

can anyone help configure bamboo to read the XML file that generated by the bamboo ant plan

iam having a problem configuring the path to the xml file

is there an example of the path 

thanks

hello

i've wondering if bamboo-findbugs-plugin-2.0-beta.jar is compatible with bamboo 2.1.1 build 1001 cause there is no data appear in the findbugs tap after the ant is completed successfully and with this message "FindBugs plugin is not run because the build has failed"  

note the path to the xml result is also configured

cheers

Hi there,

with Bamboo 2.3 we get the error:

21-Aug-2009 13:14:08	Failed to execute plugin 'FindBugs Build Processor' with error: com.atlassian.bamboo.v2.build.BuildPlanDefinition.getRepository()Lcom/atlassian/bamboo/v2/build/repository/RepositoryV2;

Thomas

I adapted the code to Bamboo 2.3.1. If someone can give me write access to the repository I would like to check it in.

Strangely the 2.0 version works fine for our 2.4.0 installation. We use it in a Maven build with the org.codehaus.mojo:findbugs-maven-plugin.